Skip to content

Conversation

@CGNonofr
Copy link

@CGNonofr CGNonofr commented Dec 3, 2024

Description

Currently, engines can only be in cjs, the PR changes that to support ESM engines

I will need help to update the tests, because some are already failing locally before my changes 🤔

I've only manually confirmed that commonjs engines still work

Pre-merge checklist

This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.

  • Does this require an update to the docs?
  • Does this require a changelog entry?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Loïc Mangeonjean seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants