add imb3588 board support #8267
Conversation
imb3588 board info link: https://www.sunshine-tek.com/productinfo/1989232.html Signed-off-by: Jack Huang <[email protected]>
JackHuang021
requested review from
SuperKali,
Tonymac32,
amazingfate,
catalinii,
chainsx,
efectn,
ginkage,
krachlatte,
monkaBlyat,
prahal,
rpardini,
schwar3kat,
sputnik2019,
ColorfulRhino,
lanefu and
igorpecovnik
as code owners
WalkthroughA new board configuration file named Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
size/large
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
config/boards/imb3588.conf (1)
1-2: Fix typo and update supported RAM sizes in headerThe header comment has a typo ("16GBB") and omits mention of the 32GB RAM option. Please correct it to reflect the actual supported RAM sizes (4GB, 8GB, 16GB, and 32GB).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
patch/kernel/rk35xx-vendor-6.1/0001-arm64-dts-add-imb3588-dts.patchis excluded by!patch/**patch/u-boot/legacy/u-boot-radxa-rk35xx/defconfig/imb3588_defconfigis excluded by!patch/**
📒 Files selected for processing (1)
config/boards/imb3588.conf(1 hunks)
🔇 Additional comments (2)
config/boards/imb3588.conf (2)
12-15: Configuration flags align with board requirementsThe SPI support, SPL loader, and GPT partition settings correctly match the IMB3588 hardware design and build objectives. No further changes needed here.
6-11:❓ Verification inconclusive
Verify referenced defconfig and device tree blob exist
Ensure that
imb3588_defconfigandrockchip/rk3588-yx-imb3588.dtbare present at the expected paths in the repo. You can run:
🏁 Script executed:
#!/bin/bash # Verify the defconfig file exists fd 'imb3588_defconfig' -t f # Verify the device tree blob exists fd 'rk3588-yx-imb3588.dtb' -t fLength of output: 59
Verify presence of defconfig and DTB files
It looks like neither
imb3588_defconfignorrockchip/rk3588-yx-imb3588.dtbwere found in the repo. Please ensure that these files exist at the expected locations, for example:
config/defconfig/imb3588_defconfigarch/arm/boot/dts/rockchip/rk3588-yx-imb3588.dtbIf they live in a different directory or use a different name, update the paths in
config/boards/imb3588.confaccordingly or add the missing files.
patch/kernel/rk35xx-vendor-6.1/0001-arm64-dts-add-imb3588-dts.patch
Outdated
Show resolved
Hide resolved
Signed-off-by: Jack Huang <[email protected]>
github-actions
bot
removed
the
Ready to merge
| @@ -0,0 +1,15 @@ | |||
| # Rockchip RK3588 SoC with 4/8/16GB RAM, 16GBB/32GB/64GB/128GB EMMC, | |||
| # m.2 SATA, USB3, USB2, 2xGbE, WIFI6, BT5.1, LCDS, MIPI, eDP, HDMI | |||
There was a problem hiding this comment.
I think all board config files consist of a 1 liner of basic hw description. I suggest to adjust accordingly. I'm also not sure how the framework handles this situation.
| @@ -0,0 +1,1337 @@ | |||
| From 1de1d6241c18c9ae5dea66b0007d61163c7122f5 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Since dt has been added to linux-rockchip repo, this whole file can be removed?
Description
Add support for IMB3588 board. This board based RK3588 SoC, with 4G/8G/16G/32GB LPDDR4 & 16G~128G emmc, 2x 1Gbps Ethernet, 1x HDMI 2.1 output, 1x eDP, 1x mipi display, 1x LVDS, AP6275P wifi 6 & buletooth 5.1 module.
IMB3588 board info: https://www.sunshine-tek.com/productinfo/1989232.html
Documentation summary for feature / change
mesa-vpuextensions will get mali GPU worked.How Has This Been Tested?
I have built an image for my board, it boots and worked fine except bluetooth.
Checklist: