Include priorityClass in armada:queue:resource:(queued|allocated) rules - #5127
Open
JamesMurkin wants to merge 1 commit into
Open
Include priorityClass in armada:queue:resource:(queued|allocated) rules#5127JamesMurkin wants to merge 1 commit into
JamesMurkin wants to merge 1 commit into
Conversation
The underlying metrics have priorityClass in them, as we don't include it in the grouping it actually undercounts the values This fixes the rules producing misleading data when queues use multiple priority classes Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
JamesMurkin
marked this pull request as ready for review
August 21, 2026 15:48
Contributor
Greptile SummaryThis PR preserves the existing
Confidence Score: 5/5The PR appears safe to merge with no identified correctness or security issues. The underlying metrics already emit a bounded priority-class label, both aggregation levels now preserve it consistently, and the only in-repository downstream consumer explicitly sums across that dimension.
|
| Filename | Overview |
|---|---|
| deployment/armada/templates/prometheusrule.yaml | Correctly retains the bounded priorityClass label in queued and allocated recording rules; no actionable regression was identified. |
Reviews (1): Last reviewed commit: "Include priorityClass in armada:queue:re..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying metrics have priorityClass in them, as we don't include it in the grouping it actually undercounts the values
This fixes the rules producing misleading data when queues use multiple priority classes