Skip to content

Include priorityClass in armada:queue:resource:(queued|allocated) rules - #5127

Open
JamesMurkin wants to merge 1 commit into
masterfrom
fix_queue_resource_recording_rule
Open

Include priorityClass in armada:queue:resource:(queued|allocated) rules#5127
JamesMurkin wants to merge 1 commit into
masterfrom
fix_queue_resource_recording_rule

Conversation

@JamesMurkin

Copy link
Copy Markdown
Contributor

The underlying metrics have priorityClass in them, as we don't include it in the grouping it actually undercounts the values

This fixes the rules producing misleading data when queues use multiple priority classes

The underlying metrics have priorityClass in them, as we don't include it in the grouping it actually undercounts the values

This fixes the rules producing misleading data when queues use multiple priority classes

Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
@JamesMurkin
JamesMurkin marked this pull request as ready for review August 21, 2026 15:48
@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR preserves the existing priorityClass dimension when aggregating queued and allocated resource metrics, preventing resources from different priority classes from being collapsed by max.

  • Adds priorityClass to both aggregation stages of armada:queue:resource:queued.
  • Adds priorityClass to both aggregation stages of armada:queue:resource:allocated.
  • Existing in-repository consumers aggregate across the new dimension where appropriate.

Confidence Score: 5/5

The PR appears safe to merge with no identified correctness or security issues.

The underlying metrics already emit a bounded priority-class label, both aggregation levels now preserve it consistently, and the only in-repository downstream consumer explicitly sums across that dimension.

Important Files Changed

Filename Overview
deployment/armada/templates/prometheusrule.yaml Correctly retains the bounded priorityClass label in queued and allocated recording rules; no actionable regression was identified.

Reviews (1): Last reviewed commit: "Include priorityClass in armada:queue:re..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant