added myself to mergify for reviewing, I missed a line the first time… - #5126
added myself to mergify for reviewing, I missed a line the first time…#5126sarhiri wants to merge 2 commits into
Conversation
… I did it Signed-off-by: sarhiri <m.sofiasarhiri@gmail.com>
Greptile SummaryThis PR completes
Confidence Score: 5/5The PR appears safe to merge because it completes an existing maintainer allowlist entry without changing the Mergify rule structure. The exact anchored account name is added to the previously omitted approval condition, bringing the two applicable maintainer approval paths into alignment without introducing a reachable configuration failure.
|
| Filename | Overview |
|---|---|
| .mergify.yml | Adds sarhiri to the Lookout UI maintainer author allowlist, consistently with the account’s existing entry in the general maintainer rule. |
Reviews (2): Last reviewed commit: "Merge branch 'master' into sarhiri-revie..." | Re-trigger Greptile
| - and: | ||
| - "#approved-reviews-by>=1" | ||
| - "author~=^(d80tb7|dave[-]gantenbein|dejanzele|eleanorpratt|geaere|JamesMurkin|mauriceyap|masipauskas|MustafaI|zuqq|richscott|robertdavidsmith|samclark|suprjinx|EnricoMi|nikola-jokic|dslear|d2burkhalter|ianhockett|Sigele|williamvega|tgucks|YHines004|j8169)$" | ||
| - "author~=^(d80tb7|dave[-]gantenbein|dejanzele|eleanorpratt|geaere|JamesMurkin|mauriceyap|masipauskas|MustafaI|zuqq|richscott|robertdavidsmith|samclark|suprjinx|EnricoMi|nikola-jokic|dslear|d2burkhalter|ianhockett|Sigele|williamvega|tgucks|YHines004|j8169|sarhiri)$" |
There was a problem hiding this comment.
Maintainer roster is out of sync
Adding sarhiri to the one-approval Mergify allowlist without adding the account to MAINTAINERS.md leaves the documented roster inconsistent with the elevated review privilege, making maintainer status harder to audit.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
… I did it
What type of PR is this?
Housekeeping
What this PR does / why we need it
Adds me fully for "maintainer" status, I missed a line last nime
Which issue(s) this PR fixes
N/A
Fixes #
N/A
Special notes for your reviewer