Skip to content

added myself to mergify for reviewing, I missed a line the first time… - #5126

Draft
sarhiri wants to merge 2 commits into
armadaproject:masterfrom
sarhiri:sarhiri-reviewer-status
Draft

added myself to mergify for reviewing, I missed a line the first time…#5126
sarhiri wants to merge 2 commits into
armadaproject:masterfrom
sarhiri:sarhiri-reviewer-status

Conversation

@sarhiri

@sarhiri sarhiri commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

… I did it

What type of PR is this?

Housekeeping

What this PR does / why we need it

Adds me fully for "maintainer" status, I missed a line last nime

Which issue(s) this PR fixes

N/A

Fixes #
N/A

Special notes for your reviewer

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR completes sarhiri’s maintainer configuration by adding the account to the reduced-approval author allowlist for Lookout UI changes.

  • Aligns the Lookout UI approval rule with the existing general Armada maintainer approval rule.
  • Preserves the established anchored username-matching pattern and Mergify rule structure.

Confidence Score: 5/5

The PR appears safe to merge because it completes an existing maintainer allowlist entry without changing the Mergify rule structure.

The exact anchored account name is added to the previously omitted approval condition, bringing the two applicable maintainer approval paths into alignment without introducing a reachable configuration failure.

Important Files Changed

Filename Overview
.mergify.yml Adds sarhiri to the Lookout UI maintainer author allowlist, consistently with the account’s existing entry in the general maintainer rule.

Reviews (2): Last reviewed commit: "Merge branch 'master' into sarhiri-revie..." | Re-trigger Greptile

Comment thread .mergify.yml
- and:
- "#approved-reviews-by>=1"
- "author~=^(d80tb7|dave[-]gantenbein|dejanzele|eleanorpratt|geaere|JamesMurkin|mauriceyap|masipauskas|MustafaI|zuqq|richscott|robertdavidsmith|samclark|suprjinx|EnricoMi|nikola-jokic|dslear|d2burkhalter|ianhockett|Sigele|williamvega|tgucks|YHines004|j8169)$"
- "author~=^(d80tb7|dave[-]gantenbein|dejanzele|eleanorpratt|geaere|JamesMurkin|mauriceyap|masipauskas|MustafaI|zuqq|richscott|robertdavidsmith|samclark|suprjinx|EnricoMi|nikola-jokic|dslear|d2burkhalter|ianhockett|Sigele|williamvega|tgucks|YHines004|j8169|sarhiri)$"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Maintainer roster is out of sync

Adding sarhiri to the one-approval Mergify allowlist without adding the account to MAINTAINERS.md leaves the documented roster inconsistent with the elevated review privilege, making maintainer status harder to audit.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@sarhiri
sarhiri marked this pull request as draft August 21, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant