Add cj87holler to Mergify maintainer lists - #5125
Conversation
Signed-off-by: cj87holler <17093384+cj87holler@users.noreply.github.com>
Greptile SummaryThis repository-configuration change adds
Confidence Score: 5/5The PR appears safe to merge because the intended maintainer account is added consistently to both applicable Mergify rules. The change is limited to adding one account to two existing allow-lists, and no concrete defect or unintended rule behavior was identified.
|
| Filename | Overview |
|---|---|
| .mergify.yml | Adds the new maintainer account consistently to both one-approval author allow-lists without changing rule structure. |
Reviews (1): Last reviewed commit: "Add cj87holler to Mergify maintainer lis..." | Re-trigger Greptile
There was a problem hiding this comment.
Added GH handle to approvers/maintainers
|
Thanks @sarhiri and @dave-gantenbein for the reviews. Flagging that this is blocked by a bootstrap issue rather than anything in the diff: Mergify evaluates .mergify.yml from the base branch, so this PR can't satisfy the maintainer-author condition it's adding. The #approved-reviews-by>=2 branch also isn't met, it looks like only one of the two approvals is counting, since Mergify only counts reviewers with write access. @mauriceyap could you add an approval? That should get to two counting approvals and turn the check green without needing an override |
What type of PR is this? Chore - repository configuration
What this PR does / why we need it: Adds 'cj87holler' to maintainer allow-list in both
.mergify.ymlandpull_request_rules, so that approvals from thsi account satisfy the single-approval condition in the same way as existing maintainers. No rule logic is changed - this is a two-line addition to the existingauthor~=^(...)regexes.Which issue(s) this PR fixes
N/A
Special notes for your reviewer
I'm joining as a maintainer and this is my first PR to the repo. I will mainly be collaborating with @sarhiri on documentation and website changes.