Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<p>
<a href="https://circleci.com/gh/armadaproject/armada"><img src="https://circleci.com/gh/helm/helm.svg?style=shield" alt="CircleCI"></a>
<a href="https://goreportcard.com/report/github.com/armadaproject/armada"><img src="https://goreportcard.com/badge/github.com/armadaproject/armada" alt="Go Report Card"></a>
<a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield" alt="FOSSA Status"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield"/></a>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The new FOSSA badge is missing the two-space indentation that all other badges in this block use, and the alt attribute is placed on the <a> tag instead of the <img> tag (the <img> has no alt text). The other badges follow the pattern of putting alt on the <img> element.

Suggested change
<a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield" alt="FOSSA Status"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield"/></a>
<a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield" alt="FOSSA Status"/></a>

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

<a href="https://artifacthub.io/packages/helm/gresearch/armada" title="Go to Artifact Hub"><img src="https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/armada" alt="Artifact Hub"></a>
<a href="https://insights.linuxfoundation.org/project/armada" title="Click to view project insights and health checks"><img src="https://insights.linuxfoundation.org/api/badge/health-score?project=armada" alt="LFX Health Score"></a>
</p>
Expand Down Expand Up @@ -239,3 +240,7 @@ For more information about contributing to Armada see [CONTRIBUTING.md](https://
## Discussion

If you are interested in discussing Armada you can find us on [![slack](https://img.shields.io/badge/slack-armada-brightgreen.svg?logo=slack)](https://cloud-native.slack.com/?redir=%2Farchives%2FC03T9CBCEMC)


## License
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a trailing newline. Most editors and linters expect text files to end with a newline character, and many CI checks (e.g., git diff heuristics) will flag this.

Suggested change
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large)
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large)