Skip to content

Add my github handle to mergify config#4821

Merged
dave-gantenbein merged 4 commits intoarmadaproject:masterfrom
sarhiri:add-sofia-gh-handle
Apr 10, 2026
Merged

Add my github handle to mergify config#4821
dave-gantenbein merged 4 commits intoarmadaproject:masterfrom
sarhiri:add-sofia-gh-handle

Conversation

@sarhiri
Copy link
Copy Markdown
Contributor

@sarhiri sarhiri commented Apr 7, 2026

What type of PR is this?

Housekeeping, added my handle to mergify.yaml

What this PR does / why we need it

Housekeeping, added my handle to mergify.yaml

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This PR adds the GitHub handle sarhiri to the Armada maintainers regex list in .mergify.yml, allowing single-approval merges for PRs authored by this user. The change is confined to the "Require approval from Armada maintainers" rule and does not touch the "Lookout UI" frontend maintainers rule, which appears intentional.

Confidence Score: 5/5

Safe to merge — single-line config addition with no logic impact.

The change is a trivial append of one GitHub handle to a regex in a Mergify config file. No logic, behavior, or security properties are altered beyond granting the new maintainer single-approval merge rights, which is the intended purpose of this PR.

No files require special attention.

Important Files Changed

Filename Overview
.mergify.yml Appends sarhiri to the Armada maintainers regex in the second PR rule; no other changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Opened] --> B{PR touches internal/lookoutui/?}
    B -- No --> C[Rule 1: Pass — no UI files]
    B -- Yes --> D{2+ approvals?}
    D -- Yes --> E[Rule 1: Pass]
    D -- No --> F{Author is frontend/Armada maintainer?}
    F -- Yes --> G[Rule 1: Pass with 1 approval]
    F -- No --> H[Rule 1: Fail]

    A --> I{Only UI files?}
    I -- Yes --> J[Rule 2: Pass — UI-only PR]
    I -- No --> K{2+ approvals?}
    K -- Yes --> L[Rule 2: Pass]
    K -- No --> M{Author is Armada maintainer?\ne.g. sarhiri — newly added}
    M -- Yes --> N[Rule 2: Pass with 1 approval]
    M -- No --> O[Rule 2: Fail]
Loading

Reviews (4): Last reviewed commit: "Merge branch 'master' into add-sofia-gh-..." | Re-trigger Greptile

@dave-gantenbein dave-gantenbein enabled auto-merge (squash) April 9, 2026 18:35
@dave-gantenbein dave-gantenbein merged commit dce68bf into armadaproject:master Apr 10, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants