Skip to content

Revert "ci(mergify): upgrade configuration to current format (#4784)"#4791

Open
mauriceyap wants to merge 1 commit intomasterfrom
revert-mergify-2
Open

Revert "ci(mergify): upgrade configuration to current format (#4784)"#4791
mauriceyap wants to merge 1 commit intomasterfrom
revert-mergify-2

Conversation

@mauriceyap
Copy link
Copy Markdown
Collaborator

This reverts commit e0139d8.

This reverts commit e0139d8.

Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 20, 2026

Greptile Summary

This PR reverts commit e0139d8 (PR #4784), which had upgraded the Mergify configuration from the pull_request_rules + post_check format to the newer merge_protections format. The revert restores the original configuration structure.

Key changes:

  • Reverts top-level key from merge_protections back to pull_request_rules
  • Restores conditions: / actions: post_check: success_conditions: structure in place of the if: / success_conditions: pattern used by merge_protections
  • Re-adds the title fields for each rule (these had been dropped during the upgrade since there was no equivalent in the merge_protections format)
  • Removes migration-related comments that were added by the upgrade commit
  • No changes to the underlying approval logic or maintainer lists

Confidence Score: 5/5

  • This PR is safe to merge — it is a clean revert of a CI configuration change with no logic modifications.
  • The change affects only the Mergify CI configuration file. It is a straightforward revert to the previously working pull_request_rules + post_check format. The approval logic and maintainer lists are identical to what existed before the reverted commit. No application code is touched.
  • No files require special attention.

Important Files Changed

Filename Overview
.mergify.yml Reverts Mergify config from the newer merge_protections format back to the older pull_request_rules + post_check action format, restoring the title fields and removing migration comments. Logic is functionally equivalent.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Opened] --> B{Has ≥1 approval?}
    B -- No --> C[post_check: pending]
    B -- Yes --> D{Touches internal/lookoutui/?}

    D -- No --> E[Rule 1: Lookout UI check\nNot a Lookout UI PR → PASS]
    D -- Yes --> F{Only Lookout UI files?}

    F -- No --> G[Rule 2: Maintainer check\nMixed files → need ≥2 approvals\nor 1 approval from maintainer]
    F -- Yes --> H[Rule 2: Only Lookout UI files → PASS]

    D -- Yes --> I[Rule 1: Lookout UI check\n≥2 approvals OR\n1 approval + author is frontend/maintainer?]
    I -- No --> J[post_check: FAIL]
    I -- Yes --> K[post_check: PASS]

    G -- Met --> K
    G -- Not Met --> J
    E --> K
    H --> K
Loading

Last reviewed commit: "Revert "ci(mergify):..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants