-
Notifications
You must be signed in to change notification settings - Fork 38
Add Reviewer Guidance: Comment/Approve/ Request Changes. #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: arm-software
Are you sure you want to change the base?
Conversation
|
|
||
| How to Review a Pull Request | ||
|
|
||
| When reviewing a PR, you can provide feedback, approve the changes, or request updates using GitHub’s standard review options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would everyone have the permissions to approve or request changes?
|
|
||
| How to Review a Pull Request | ||
|
|
||
| When reviewing a PR, you can provide feedback, approve the changes, or request updates using GitHub’s standard review options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| When reviewing a PR, you can provide feedback, approve the changes, or request updates using GitHub’s standard review options: | |
| When reviewing a PR, you can provide feedback, approve the PR, or request changes using GitHub’s standard review options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this suggestion
| Please attach any support files to the issue itself, | ||
| see [Attaching files](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/attaching-files). | ||
|
|
||
| ### Reviewing Patches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a context for these changes? Otherwise it seems like stating the obvious. Is this for engineers who have not worked with Github before?
saturn691
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Kiran's comments
|
|
||
| How to Review a Pull Request | ||
|
|
||
| When reviewing a PR, you can provide feedback, approve the changes, or request updates using GitHub’s standard review options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this suggestion
No description provided.