Update run_fvp and run_qemu scripts, to capture and return the stdout and stderr to the calling function. #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrukesh
force-pushed
the
vrukesh_atfe_data_error
branch
from
9e05623 to
519ddef
Compare
vrukesh
force-pushed
the
vrukesh_atfe_data_error
branch
from
519ddef to
917487c
Compare
statham-arm
reviewed
Jul 15, 2025
| @@ -212,4 +212,4 @@ def run_fvp( | |||
| result_stdout = result.stdout | |||
|
|
|||
| sys.stdout.buffer.write(result_stdout) | |||
| return result.returncode | |||
| return result.returncode, result.stdout.decode(), result.stderr.decode() if result.stderr != None else "" | |||
There was a problem hiding this comment.
In this kind of situation it's a good idea to add the errors='replace' argument to the decode calls. Then any bytes that aren't legal UTF-8 will be turned into a Unicode replacement character � instead of causing an exception.
If the program under test does emit invalid UTF-8, we still want to see in the log file what it was, so that we can get a clue about what went wrong. A Python exception that stops the script from showing us the useful detail isn't good for anyone.
vrukesh
force-pushed
the
vrukesh_atfe_data_error
branch
from
917487c to
cc8e173
Compare
… and stderr to the calling function.
vrukesh
force-pushed
the
vrukesh_atfe_data_error
branch
from
cc8e173 to
4efbe39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update run_fvp and run_qemu scripts, to capture and return the stdout and stderr to the calling functions.
This can also be useful for automation, and viewing the error strings.