Activity

1. shubertm commented on Feb 5, 2026

   

   shubertm

   on Feb 5, 2026

   Contributor

   More actions

   @bordalix can I take up this issue?
2. bordalix commented on Feb 5, 2026

   

   bordalix

   on Feb 5, 2026

   ContributorAuthor

   More actions

   @shubertm sure

   👍React with 👍1Reacted by Shubert Munthali
3. shubertm commented on Feb 7, 2026

   

   shubertm

   on Feb 7, 2026

   Last edited by shubertm

   Contributor

   More actions

   DB Usage Verification

   WalletRepositoryImpl

   There are 4 usages of WalletRepositoryImpl, in 3 of these usages it is explicitly supplied with db instances. Only one adds a fallback in to in-memory storage, the default for this place is db as well.

   ts-sdk/src/wallet/serviceWorker/wallet.ts

   Lines 89 to 100 in f139452

   	const createCommon = (options: ServiceWorkerWalletCreateOptions) => {
   	// Default to IndexedDB for service worker context
   	const storage = new IndexedDBStorageAdapter(
   	options.dbName || DEFAULT_DB_NAME,
   	options.dbVersion
   	);
   	// Create repositories
   	return {
   	walletRepo: new WalletRepositoryImpl(storage),
   	contractRepo: new ContractRepositoryImpl(storage),
   	};
   	};

   ts-sdk/src/wallet/serviceWorker/worker.ts

   Lines 126 to 135 in f139452

   	constructor(
   	readonly dbName: string = DEFAULT_DB_NAME,
   	readonly dbVersion: number = 1,
   	private readonly messageCallback: (
   	message: ExtendableMessageEvent
   	) => void = () => {}
   	) {
   	this.storage = new IndexedDBStorageAdapter(dbName, dbVersion);
   	this.walletRepository = new WalletRepositoryImpl(this.storage);
   	}

   ts-sdk/src/wallet/serviceWorker/worker.ts

   Lines 200 to 212 in f139452

   	async clear() {
   	if (this.incomingFundsSubscription) this.incomingFundsSubscription();
   	// Clear storage - this replaces vtxoRepository.close()
   	await this.storage.clear();
   	// Reset in-memory caches by recreating the repository
   	this.walletRepository = new WalletRepositoryImpl(this.storage);
   	this.handler = undefined;
   	this.arkProvider = undefined;
   	this.indexerProvider = undefined;
   	}

   ts-sdk/src/wallet/wallet.ts

   Lines 221 to 224 in f139452

   	// Set up storage and repositories
   	const storage = config.storage || new InMemoryStorageAdapter();
   	const walletRepository = new WalletRepositoryImpl(storage);
   	const contractRepository = new ContractRepositoryImpl(storage);

   ContractRepositoryImpl

   There are 2 usages of ContractRepositoryImpl, both of them are supplied with db instances
   

   ts-sdk/src/wallet/serviceWorker/wallet.ts

   Lines 89 to 100 in f139452

   	const createCommon = (options: ServiceWorkerWalletCreateOptions) => {
   	// Default to IndexedDB for service worker context
   	const storage = new IndexedDBStorageAdapter(
   	options.dbName || DEFAULT_DB_NAME,
   	options.dbVersion
   	);
   	// Create repositories
   	return {
   	walletRepo: new WalletRepositoryImpl(storage),
   	contractRepo: new ContractRepositoryImpl(storage),
   	};
   	};

   ts-sdk/src/wallet/wallet.ts

   Lines 221 to 224 in f139452

   	// Set up storage and repositories
   	const storage = config.storage || new InMemoryStorageAdapter();
   	const walletRepository = new WalletRepositoryImpl(storage);
   	const contractRepository = new ContractRepositoryImpl(storage);
4. ghost added

   enhancementNew feature or requestNew feature or request

   on Apr 13, 2026
5. pietro909 commented on Jul 16, 2026

   

   pietro909

   on Jul 16, 2026

   Contributor

   More actions

   Status update (2026-07)

   This umbrella predates the offline-first ContractManager/repository architecture, which has since absorbed most of it. Mapping the original checklist to where things stand on master:

   • [~] getVtxos use the db — reads now route through contractManager.getContractsWithVtxos() (wallet.ts:1035,1076), but three call sites still read VTXO state directly from the indexer (fetchPendingTxs wallet.ts:1551, finalizePendingTxs wallet.ts:3846, the getTxCreatedAt callback wallet.ts:1082). Tracked separately in Wallet bypasses ContractManager with direct IndexerProvider reads in three places #550 — that's the remaining work for this item.
   • [~] getUtxos use the db — walletRepository.getUtxos() is used (wallet.ts:4755), but on-chain/boarding coins are still fetched live from Esplora (onchainProvider.getCoins wallet.ts:1337).
   • Save tx history in db — done: saveTransactions is implemented across all backends and invoked on sync (wallet.ts:4631, and in the SW handler).
   • Save boarding txs (and outspents) in db — still missing. Boarding history is re-derived from Esplora on every call via onchainProvider.getTransactions / getTxOutspends (wallet.ts:1156-1177); it is not persisted. (Related dedup/correctness fixes landed in fix: suppress duplicate history entries for swept boarding deposits #530, [codex] Fix duplicate boarding refill history entries #531, fix(wallet): phantom receive inflation from boarding sweeps (Esplora outspends without txid) #587, but none persist the boarding tx set.)
   • [~] net↔db sync issues — the repository-layer atomicity / silent-failure / cross-backend-divergence concerns are tracked in Repositories layer: atomicity, silent failures, and cross-backend divergence (review findings) #493; the stale-balance-after-reset reconcile is in flight as fix(wallet): reconcile VTXOs the indexer stops reporting (stale balance after chain reset) #585.

   What's genuinely left under this issue (not covered elsewhere): persisting boarding txs + outspents in the DB instead of re-fetching from Esplora, and closing out the last direct-indexer getVtxos reads (the latter = #550).

   Keeping this open as the tracking umbrella. The two concrete unaddressed items above are the actionable remainder; everything else here is either done or has a dedicated issue (#550, #493, #585).