Update eval_tracking.py #267
Conversation
broke eval_tracks into smaller functions
|
|
||
|
|
||
| def eval_tracks( | ||
| def get_frame_data( |
There was a problem hiding this comment.
hey @ahuller3, how long does get_frame_data() take compared to the mot metrics eval function call?
mgilson-argo
left a comment
mgilson-argo
left a comment
There was a problem hiding this comment.
I was asked to look at PRs in here and I didn't realize until just now that this is still a draft -- sorry for any spam, but I figured I'd submit the comments I have to save you pain later.
| acc_c, | ||
| acc_i, | ||
| acc_o, | ||
| ): |
There was a problem hiding this comment.
No return type? Also no types on acc_c, acc_i, acc_o ...
Also, this function has way too many arguments. It seems like we probably needs a refactor.
|
|
||
| for ind_frame in range(len(path_track_data)): | ||
| if ind_frame % 50 == 0: | ||
| logger.info("%d/%d" % (ind_frame, len(path_track_data))) |
There was a problem hiding this comment.
Probably:
logger.info("%d/%d", ind_frame, len(path_track_data))| if ind_frame % 50 == 0: | ||
| logger.info("%d/%d" % (ind_frame, len(path_track_data))) | ||
| if not os.path.exists(path_gt): | ||
| logger.warning("Missing ", path_gt) |
There was a problem hiding this comment.
Missing a placeholder in this log format string.
| def write_summary_to_file( | ||
| acc_c, | ||
| acc_o, | ||
| ID_gt_all: List[str], |
There was a problem hiding this comment.
Does this actually have to be List or can it be Collection or Iterable or Sequence?
3 participants
Broke eval_tracks into smaller functions. Still needs comments and some type annotations.