Skip to content

In SSA stack layout generation, improve multi-entry stack-in selection#16568

Merged
clonker merged 1 commit intodevelopfrom
ssa-fix-stack-layout-gen-inefficiency
Apr 1, 2026
Merged

In SSA stack layout generation, improve multi-entry stack-in selection#16568
clonker merged 1 commit intodevelopfrom
ssa-fix-stack-layout-gen-inefficiency

Conversation

@clonker
Copy link
Copy Markdown
Member

@clonker clonker commented Mar 31, 2026

The order in which handlePhiFunctions and declareJunk is called matters. When declareJunk is called first, this can junk slots which were needed for phi value replacement. This commit changes this to first handle the phi functions, only then declare junk.

Depends on #16566

@clonker clonker added has dependencies The PR depends on other PRs that must be merged first experimental labels Mar 31, 2026
@clonker clonker force-pushed the ssa-use-gas-to-find-stack-size branch from 6b35a46 to b77ab0d Compare March 31, 2026 11:11
@clonker clonker force-pushed the ssa-fix-stack-layout-gen-inefficiency branch from 01dd18a to 5d168c2 Compare March 31, 2026 11:12
@clonker clonker marked this pull request as ready for review March 31, 2026 11:22
@clonker clonker force-pushed the ssa-use-gas-to-find-stack-size branch from b77ab0d to 2c52349 Compare March 31, 2026 12:29
@clonker clonker force-pushed the ssa-fix-stack-layout-gen-inefficiency branch from 5d168c2 to 444f096 Compare March 31, 2026 12:33
@clonker clonker force-pushed the ssa-use-gas-to-find-stack-size branch from 2c52349 to 2e274f8 Compare March 31, 2026 13:44
@clonker clonker force-pushed the ssa-fix-stack-layout-gen-inefficiency branch from 444f096 to cd9e6e9 Compare March 31, 2026 13:45
Base automatically changed from ssa-use-gas-to-find-stack-size to develop March 31, 2026 14:31
@clonker clonker force-pushed the ssa-fix-stack-layout-gen-inefficiency branch 2 times, most recently from d7d923d to 390e64b Compare April 1, 2026 07:58
@clonker clonker force-pushed the ssa-fix-stack-layout-gen-inefficiency branch from 390e64b to a05041a Compare April 1, 2026 08:04
Copy link
Copy Markdown
Contributor

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Way less junk :)

@clonker clonker enabled auto-merge April 1, 2026 08:30
@clonker clonker merged commit 0164881 into develop Apr 1, 2026
81 of 82 checks passed
@clonker clonker deleted the ssa-fix-stack-layout-gen-inefficiency branch April 1, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental has dependencies The PR depends on other PRs that must be merged first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants