In SSA stack layout generation, improve multi-entry stack-in selection#16568
Merged
In SSA stack layout generation, improve multi-entry stack-in selection#16568
Conversation
6b35a46 to
b77ab0d
Compare
01dd18a to
5d168c2
Compare
b77ab0d to
2c52349
Compare
5d168c2 to
444f096
Compare
2c52349 to
2e274f8
Compare
444f096 to
cd9e6e9
Compare
d7d923d to
390e64b
Compare
390e64b to
a05041a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order in which
handlePhiFunctionsanddeclareJunkis called matters. WhendeclareJunkis called first, this can junk slots which were needed for phi value replacement. This commit changes this to first handle the phi functions, only then declare junk.Depends on #16566