Closed
Conversation
msooseth
changed the title
msooseth
force-pushed
the
develop-ossfuzz
branch
from
0a27a38 to
9825b60
Compare
None of this Less noise Update Compile now Less noise
msooseth
force-pushed
the
develop-ossfuzz
branch
from
9825b60 to
c354c02
Compare
r0qs
reviewed
Mar 2, 2026
r0qs
reviewed
Mar 2, 2026
msooseth
commented
Mar 2, 2026
r0qs
requested changes
Mar 3, 2026
msooseth
changed the title
r0qs
reviewed
Mar 3, 2026
r0qs
reviewed
Mar 3, 2026
msooseth
force-pushed
the
develop-ossfuzz
branch
2 times, most recently
from
f70f8ab to
8258e60
Compare
cameel
reviewed
Mar 13, 2026
Collaborator
There was a problem hiding this comment.
Changes to the interpreter should be covered with tests in libyul/yulInterpreterTests/.
Contributor
Author
There was a problem hiding this comment.
VERY good catch. There was actually a bug introduced here that these tests caught. I fixed that, and added more test cases around wrapping for both memory and storage.
msooseth
force-pushed
the
develop-ossfuzz
branch
from
f4da40c to
9fe3e77
Compare
No flat map
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are:
m_filterOptimizationNoise.pragma experimentalin solc is too easy to crash, and is unsupported -- filtering outInstructionLimitReachedand an associated "cost" for instructions... gas, basically :)I also improved the README so we have some explanation of what some of the binaries do. It has been hard to figure out what is what, and what it actually tests without it.