Skip to content

playwright stabilization reasons #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2025
Merged

playwright stabilization reasons #194

merged 3 commits into from
Apr 12, 2025

Conversation

gregberge
Copy link
Member

  • fix: remove unrelevant code to load images in waitForAriaBusy
  • fix(playwright): properly return stabilization failure reasons
  • chore(playwright): change the order of operations before taking the screenshot

@gregberge gregberge requested review from a team and jsfez and removed request for a team April 12, 2025 18:54
@vercel Vercel
Copy link

vercel bot commented Apr 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
argos-js-sdk-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2025 6:55pm

@gregberge gregberge merged commit a9132af into main Apr 12, 2025
54 checks passed
@gregberge gregberge deleted the playwright-stabilization-reasons branch April 12, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsfez jsfez Awaiting requested review from jsfez jsfez was automatically assigned from argos-ci/core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gregberge