Add dataset access control for model configurations#81
Open
Conversation
- Add 'datasets' field to models.yml for controlling which datasets a model can access - Default to public-v1 and public-v2 only; private datasets require explicit opt-in - Add get_allowed_datasets() and is_dataset_allowed() utilities in task_utils.py - Add cli/check_dataset.py for validating dataset access from shell scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datasetsfield to models.yml for controlling which datasets a model can access["public-v1", "public-v2"]only; private datasets require explicit opt-inget_allowed_datasets()andis_dataset_allowed()utilities in task_utils.pycli/check_dataset.pyfor validating dataset access from shell scriptsDataset Configuration
Models without a
datasetsfield default to public datasets only:To allow private datasets, add explicit configuration:
Test plan
cli/check_dataset.pyreturns exit code 0 for allowed datasetscli/check_dataset.pyreturns exit code 1 for disallowed datasetsdatasetsfield default to public only