Merged
Conversation
add view dialog add updated at to edit dialog
merge dev into stage
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges changes from stage into main, primarily updating exercise behavior across the backend (DB + services + tests) and frontend (table + dialog) while improving search indexing correctness.
Changes:
- Make
exercises.namecase-insensitive at the DB level (PostgresCITEXT) and update conflict tests accordingly. - Adjust exercise querying/ordering and ensure
updated_atchanges when only muscle groups are modified. - Add “view” mode for system exercises in the client and extend the shared DataTable column
metato support responsive header/cell classes; ensure Meilisearch settings updates complete before document indexing.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/app/tests/services/search/test_reindex.py | Update search reindex test fakes to match task-id return values. |
| server/app/tests/services/exercise/test_update_exercise.py | Add coverage for muscle-group-only updates; update name-conflict case-insensitive expectation. |
| server/app/tests/services/exercise/test_get_exercises.py | Update ordering expectations to “custom first, then system” ordering. |
| server/app/tests/services/exercise/test_create_exercise.py | Update name-conflict test to validate case-insensitive uniqueness. |
| server/app/tests/services/_utilities/queries/test_query_exercises.py | Update ordering test to include system + user exercises and verify ordering grouping. |
| server/app/tests/api/exercise/test_update_exercise.py | Update API name-conflict test to validate case-insensitive uniqueness. |
| server/app/tests/api/exercise/test_create_exercise.py | Update API name-conflict test and document the case-insensitive expectation. |
| server/app/services/utilities/queries.py | Change exercise ordering to prioritize custom exercises before system exercises. |
| server/app/services/search.py | Wait for Meilisearch settings tasks to complete before adding documents. |
| server/app/services/exercise.py | Manually bump updated_at when only muscle group relationships change. |
| server/app/models/database/exercise.py | Change Exercise.name column type to CITEXT for case-insensitive behavior. |
| server/app/migrations/versions/2026_03_27_2337-e87490ac7ad5_change_exercise_name_to_case_insensitive.py | Add Alembic migration to create citext extension and alter the name column type. |
| client/src/components/exercises/ExercisesTable.tsx | Add system-exercise “view” action; adjust column rendering and responsive behavior. |
| client/src/components/exercises/ExerciseFormDialog.tsx | Add “view” mode with read-only rendering and move “Last Updated” display into the dialog. |
| client/src/components/data-table/DataTableViewOptions.tsx | Export DataTableColumnMeta and add header/cell class hooks. |
| client/src/components/data-table/DataTable.tsx | Apply headerClassName/cellClassName from column meta when rendering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.