Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
Merges staging changes into main, primarily updating dependency lockfiles and adding an automated Meilisearch reindex workflow (service code + infra wiring) to ensure search indexes are rebuilt in deployment environments.
Changes:
- Bump server/client/tooling dependencies (Python
uv.lock, root/client npm lockfiles). - Update Meilisearch reindex behavior to delete existing indexes before rebuilding, with corresponding test updates.
- Add a standalone reindex script and wire it into Docker Compose as a one-off service run before the API starts.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/uv.lock | Updates Python dependency lock entries (fastapi-cloud-cli, meilisearch sdk, ruff). |
| server/pyproject.toml | Excludes app/scripts/* from coverage collection. |
| server/app/services/search.py | Changes reindex() to delete existing Meilisearch indexes up-front; removes per-index deletions. |
| server/app/tests/services/search/test_reindex.py | Updates unit test to assert deletion happens prior to indexing calls. |
| server/app/scripts/reindex_meilisearch.py | Adds an async script entrypoint for full Meilisearch reindex using app settings/dependencies. |
| server/app/scripts/init.py | Declares scripts package (empty). |
| config/infra/docker-compose.yml | Renames migrations service, adds reindex-meilisearch one-off job, and makes server depend on it. |
| config/infra/docker-compose.override.yml | Adds dev build config for the renamed migration service and the reindex job. |
| package.json | Bumps npm-check-updates. |
| package-lock.json | Lockfile updates for npm-check-updates and transitive yaml. |
| client/package.json | Bumps vite. |
| client/package-lock.json | Lockfile updates for Vite and transitive rolldown bindings/pluginutils/picomatch. |
Files not reviewed (1)
- client/package-lock.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.