Skip to content

harden aur_pre_build (#2228) #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Misaka13514
Copy link
Contributor

@Misaka13514 Misaka13514 commented May 14, 2025

Fix #2228

用脚本批量了添加现有 AUR Maintainer 和 CoMaintainers

Todo:

  • AUR 上没有 Maintainer 的包:

    建议维护者在 AUR adopt 后改为 update_aur_repo 的模式

  • 因 AUR RPC 限制,未能获取到 Last Packager,若其与 Maintainer 和 CoMaintainers 不同,lilac 会拒绝

    待测试(预计今晚前完成) 已添加

grep -rl "aur_pre_build" archlinuxcn alarmcn | while read -r file; do
  if grep "aur_pre_build" "$file" |\
     grep -v "maintainers=" |\
     grep -v "^#" |\
     grep -vq "from lilaclib import aur_pre_build"
  then
    echo "$file"
  fi
done
result

可忽略

archlinuxcn/apparmor.d-git/lilac.py.bak

需修改

archlinuxcn/cataclysm-dda-ncurses/lilac.py
archlinuxcn/hpoj/lilac.py
archlinuxcn/hpoj/lilac.yaml
archlinuxcn/httpry/lilac.yaml
archlinuxcn/python-pdm-pep517/lilac.yaml

@lilacbot
Copy link
Contributor

Some maintainers (perhaps outside contributors) cannot be assigned: @yan12125, @Universebenzene, @xiaohuirong, @ykelvis, @tttturtle-russ

@xiaohuirong xiaohuirong requested review from xiaohuirong and removed request for xiaohuirong May 17, 2025 06:30
xiaohuirong added a commit that referenced this pull request May 25, 2025
@Misaka13514
Copy link
Contributor Author

重新获取了所有 maintainers,仅有一处 maintainers 改变

diff --git a/archlinuxcn/python311/lilac.py b/archlinuxcn/python311/lilac.py
index 3ab137e1a04..7c4d5ccc308 100644
--- a/archlinuxcn/python311/lilac.py
+++ b/archlinuxcn/python311/lilac.py
@@ -5,7 +5,7 @@ from lilaclib import edit_file
 
 
 def pre_build():
-    aur_pre_build(maintainers=['soh'])
+    aur_pre_build(maintainers=['Heptazhou'])
     for line in edit_file("PKGBUILD"):
         if line.startswith("provides="):
             continue

@lilydjwg
Copy link
Member

那可以准备合并了吗?

@Misaka13514
Copy link
Contributor Author

还有4个AUR包没有maintainer,我应该在PR中取消aur_pre_build还是等维护者稍后在AUR adopt后自行修改?

@lilydjwg
Copy link
Member

可以写最后打包者。

@Misaka13514 Misaka13514 marked this pull request as ready for review May 30, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

harden aur_pre_build