Explicit category order - #97
Conversation
arcanis
left a comment
There was a problem hiding this comment.
Sorry I didn't see this sooner - I think it makes sense. There's just the extra complexity in category format caching that I don't entirely understand?
| : null; | ||
|
|
||
| formattedCategories.set(category, formattedCategory); | ||
|
|
There was a problem hiding this comment.
I see what you mean; this cache is only being read in one place, so the computation of formattedCategory should be moved down to line 458 where it is being used.
There was a problem hiding this comment.
I somewhat reverted the changes. I'm not entirely sure what formatMarkdownish is doing. Which is better for commandsByCategories keys: the original category, or the markdown-formatted category?
|
For both this and #99, do you have any guidance on writing tests? I skimmed the tests and I can see the |
Implements #96
WIP to gauge if this will be accepted before I add tests.