properly handle edge cases on page/tab URLs#47
Open
wesinator wants to merge 10 commits intoarantius:masterfrom
Open
properly handle edge cases on page/tab URLs#47wesinator wants to merge 10 commits intoarantius:masterfrom
wesinator wants to merge 10 commits intoarantius:masterfrom
Conversation
Owner
|
Thanks for the PR. But:
(edit: markdown syntax) |
Author
|
@arantius happy new year, This change is now fixed, tested and works correctly |
url processing in common for page funcs close arantius#52
Author
|
I updated this to handle #52, and move the url scheme processing to common, where it gets called both in the popup script and the background script for page URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the work on this extension.
This PR adds a check to properly handle the case where the current page view is a reader mode (in Firefox), sending the actual raw URL to resurrect pages.
Enter
about:reader?url=https%3A%2F%2Fwww.howtogeek.com%2F352267%2Fhow-to-use-the-reader-view-in-firefox%2Fin browser and the resurrect pages from the toolbar links.