This repository was archived by the owner on May 22, 2025. It is now read-only.
aragon-run: Add option for --client-repo#781
Closed
chadoh wants to merge 1 commit into
Closed
Conversation
|
Thanks for opening this pull request! Someone will review it soon 🔍 |
chadoh
added a commit
to AutarkLabs/aragon-cli
that referenced
this pull request
Sep 20, 2019
This option allows setting the repo from which to download the aragon client, allowing dev teams to temporarily use a forked client while working on experimental features.aragon#781
chadoh
commented
Sep 20, 2019
|
|
||
| - Iterate `aragon run`: add `--client-repo` optional argument | ||
|
|
||
| --- |
Author
There was a problem hiding this comment.
This blurb is a placeholder. We need to fill in the correct date & release version before merging.
This option allows setting the repo from which to download the aragon client, allowing dev teams to temporarily use a forked client while working on experimental features.aragon#781
macor161
reviewed
Sep 23, 2019
Contributor
macor161
left a comment
macor161
left a comment
There was a problem hiding this comment.
Looking good to me. Just a small fix in the start command
| const DEFAULT_CLIENT_REPO = pkg.aragon.clientRepo | ||
| const DEFAULT_CLIENT_VERSION = pkg.aragon.clientVersion | ||
| const DEFAULT_CLIENT_PORT = pkg.aragon.clientPort | ||
|
|
Contributor
There was a problem hiding this comment.
Just a small fix on line 17: exports.command = 'start [client-version]' should be exports.command = 'start [client-repo] [client-version]'
0xGabi
pushed a commit
to 0xGabi/aragon-cli
that referenced
this pull request
Sep 23, 2019
This option allows setting the repo from which to download the aragon client, allowing dev teams to temporarily use a forked client while working on experimental features.aragon#781
Contributor
|
Superseded by #792 We open a new PR cause we were not able to push changes into this branch and wanted to release a new version with the changes |
0xGabi
added a commit
that referenced
this pull request
Sep 23, 2019
* aragon-run: Add option for --client-repo This option allows setting the repo from which to download the aragon client, allowing dev teams to temporarily use a forked client while working on experimental features.#781 * Include CHANGELOG * Include export.command positional argument * Fix Readme and Changelog * Update snapshots
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option allows setting the repo from which to download the aragon client, allowing dev teams to temporarily use a forked client while working on experimental features.
🦅 Pull Request
We at Autark are working toward our mainnet release. To get Projects working correctly, we need to test-drive some experimental changes to aragonAPI and the wrapper (aragon/aragon.js#361). We've set up custom repos for each of these (https://github.com/AutarkLabs/aragon-api & https://github.com/AutarkLabs/aragon-wrapper) and a version of the client that uses our experimental wrapper (AutarkLabs/aragon#27), and now we need to use that client from our Open Enterprise repo as shown here: https://github.com/AutarkLabs/open-enterprise/pull/1249/files#diff-7c6178980acb266af0692d351cfdba1cR9
🚨 Test instructions
Verify that passing the
--client-repocommand toaragon rundownloads the client from the specified repository, just as--client-versoinallows specifying the commit hash.✔️ PR Todo
--client-version, so I have not added any for--client-repo]