Skip to content

fix(misconf): ensure value used as ignore marker is non-null and known #9835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
+11 −0
Merged

fix(misconf): ensure value used as ignore marker is non-null and known #9835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/iac/scanners/terraform/executor/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@ func ignoreByParams(params map[string]string, modules terraform.Modules, m *type
}
for key, param := range params {
val := block.GetValueByPath(key)
if val.IsNull() || !val.IsKnown() {
return false
}
switch val.Type() {
case cty.String:
if val.AsString() != param {
Expand Down
8 changes: 8 additions & 0 deletions pkg/iac/scanners/terraform/ignore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,14 @@ data "aws_iam_policy_document" "this" {
}`,
assertLength: 0,
},
{
name: "ignore marker value is unknown",
source: `#trivy:ignore:*[bucket=mybucket-bucket1]
resource "aws_s3_bucket" "test" {
bucket = "mybucket-${each.key}"
}`,
assertLength: 1,
},
}

for _, tc := range testCases {
Expand Down