feat(sbom): add support for SPDX attestations #9829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for reading SPDX 2.3 attestations in DSSE envelope format following the in-toto attestation specification. Changes: - Add FormatAttestSPDXJSON format constant - Implement unified decodeAttestationFormat() function - Support https://spdx.dev/Document predicate type - Add comprehensive unit tests Related issue: aquasecurity#9828
knqyf263
force-pushed
the
spdx_predicate
branch
from
500b9af to
66e7aa3
Compare
DmitriyLewen
approved these changes
Nov 20, 2025
Contributor
DmitriyLewen
left a comment
DmitriyLewen
left a comment
There was a problem hiding this comment.
LGTM
left small comment
pkg/sbom/sbom.go
Outdated
|
|
||
| // Check SPDX | ||
| if s.PredicateType == in_toto.PredicateSPDX { | ||
| if spdxID, ok := m["SPDXID"].(string); ok && strings.HasPrefix(spdxID, "SPDX") { |
Contributor
There was a problem hiding this comment.
The document SPDXID is always SPDXRef-DOCUMENT
(see https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#63-spdx-identifier-field).
So we can compare the strings directly instead of checking for a prefix.
Change SPDXID validation from prefix check to exact match with 'SPDXRef-DOCUMENT' as per SPDX 2.3 specification. This addresses the review comment: aquasecurity#9829 (comment)
Update SPDXID in test SPDX files to use 'SPDXRef-DOCUMENT' as required by SPDX 2.3 specification.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for reading SPDX 2.3 attestations in DSSE envelope format (in-toto attestation).
Key Changes
FormatAttestSPDXJSONformat constantdecodeAttestationFormat()function that handles both CycloneDX and SPDX attestationshttps://spdx.dev/Documentpredicate type in rekor.goImplementation Details
The implementation follows the existing CycloneDX attestation pattern and reuses the SPDX unmarshaling logic. The attestation format follows the in-toto SPDX predicate specification.
Format Structure
Related issues
Checklist