refactor: remove list of services from --help output #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes listing supported AWS services when running `trivy aws --help`
Contributor
|
I partially agree. I think the list of available services can be removed from the intro message of the help command, but it is still needed for the --service and --skip-service flags. It is better to do this within a single PR along with defining the AWS group flags and default values inside this repository, as they will be removed from Trivy. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes listing supported AWS services when running
trivy aws --helpRelates to #327
As a new user of trivy and this plugin, I do not find this list helpful in the
--helpoutput.Help output should be for explaining required, recommended, and optional flags/arguments/parameters.
The README provides a list of supported services, which should be sufficient.