[proposal] Multisig account timelock#667
Merged
gregnazario merged 2 commits intoaptos-foundation:mainfrom Apr 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Aptos Improvement Proposal (AIP-145) describing an opt-in timelock feature for multisig accounts, including configuration, execution/bypass rules, timestamp tracking, and expected testing/security considerations.
Changes:
- Introduces the AIP-145 document specifying multisig timelock behavior (delay + higher-threshold bypass).
- Defines proposed on-chain data structures/events/view functions and outlines execution-time validation semantics.
- Documents invariant rules, error codes, and a test plan/reference implementation link.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+108
to
+114
| | Code | Name | Description | | ||
| |------|------|-------------| | ||
| | 2012 | `ETIMELOCK_NOT_EXPIRED` | Prologue error: quorum met but timelock delay has not elapsed | | ||
| | 21 | `EINVALID_TIMELOCK_CONFIG` | `timelock_secs` and `bypass_num_signatures` must both be positive or both zero | | ||
| | 22 | `EINVALID_TIMELOCK_DURATION` | `timelock_secs` outside valid range (1 hour – 14 days) | | ||
| | 23 | `EINVALID_TIMELOCK_BYPASS_THRESHOLD` | `bypass_num_signatures` not in valid range | | ||
|
|
There was a problem hiding this comment.
The “New Error Codes” table rows start with ||, which creates an unintended empty first column in Markdown rendering. Use single leading | for the header/separator/rows so the table renders correctly.
sherry-x
reviewed
Apr 9, 2026
sherry-x
reviewed
Apr 9, 2026
sherry-x
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes an opt-in multisig account timelock. Similar to Aptos governance, where voting must take place for X time, before the propoosal can be completed.