-
Notifications
You must be signed in to change notification settings - Fork 2
Remove using namespace std from kf namespace #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/remove-using-namespace-std
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SergiusTheBest <[email protected]>
Co-authored-by: SergiusTheBest <[email protected]>
Copilot
AI
changed the title
[WIP] Remove using namespace std inside kf namespace
Remove using namespace std from kf namespace
Nov 6, 2025
Copilot finished work on behalf of
SergiusTheBest
November 6, 2025 16:23
Member
|
…e_t/ptrdiff_t Co-authored-by: SergiusTheBest <[email protected]>
Contributor
Author
Done in e121bda. Changed to |
Copilot finished work on behalf of
SergiusTheBest
November 6, 2025 16:42
Member
|
@copilot Fix build errors. |
Co-authored-by: SergiusTheBest <[email protected]>
Contributor
Author
Copilot finished work on behalf of
SergiusTheBest
November 6, 2025 17:01
Member
|
@copilot Fix build errors. |
…invalid_argument with ASSERT Co-authored-by: SergiusTheBest <[email protected]>
Contributor
Author
Copilot finished work on behalf of
SergiusTheBest
November 6, 2025 17:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using namespace std;from include/kf/Hex.h and addstd::prefix tospanandarraytypesusing namespace std;from include/kf/EncodingDetector.husing namespace std;from include/kf/USimpleString.h and addstd::prefix tospanusing namespace std;from include/kf/TextDetector.h and addstd::prefix tospanandrangesusing namespace std;from include/kf/Base64.h (no changes needed, all uses already have std::)using namespace std;from include/kf/ArrayUtils.h (no changes needed, all uses already have std::)using namespace std;from include/kf/EarlyAllocator.h and addstd::prefix to type traitsusing namespace std;from include/kf/ASimpleString.h and addstd::prefix tospanusing namespace std;from include/kf/Scanner.husing namespace std;from include/kf/ext/timsort.h and addstd::prefix tomin,max, andswap(std::min)and(std::max)instead ofstd::minandstd::maxto be safe if they are macrosstd::prefix fromsize_tandptrdiff_tfor brevitystd::prefix tospanin all function signatures_Xinvalid_argumentwithASSERTin EarlyAllocator.h (internal STL function no longer accessible)Summary
Successfully removed all instances of
using namespace stdfrom within thekfnamespace across 10 header files. Added explicitstd::prefixes to standard library types and functions where needed, using macro-safe syntax forminandmax. Fixed all build errors by:spanreferences in function signatures have thestd::prefix_Xinvalid_argumentcalls withASSERTin noexcept functionsThe changes eliminate namespace pollution and follow C++ best practices while maintaining brevity for common types like
size_tandptrdiff_t.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.