Skip to content

Conversation

@belyshevdenis
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive test coverage for the SpanUtils utility functions. The changes include setting up test infrastructure to handle error cases and implementing thorough unit tests for all SpanUtils functions.

  • Test infrastructure updates to track calls to std::_Xinvalid_argument for error condition testing
  • Comprehensive test coverage for all SpanUtils functions including span_cast, as_bytes, copyTruncate, copyExact, copy, equals, indexOf, split, and atOrDefault
  • Removal of using namespace std directive in favor of explicit std:: prefixes

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
test/pch.h Adds test infrastructure for tracking _Xinvalid_argument calls and introduces _invoke_watson function
test/pch.cpp Defines global counter for tracking _Xinvalid_argument calls
test/SpanUtilsTest.cpp Comprehensive test suite covering all SpanUtils functions with various scenarios
test/CMakeLists.txt Adds SpanUtilsTest.cpp to the build configuration
include/kf/SpanUtils.h Removes using namespace std and adds explicit std:: prefixes throughout
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

belyshevdenis and others added 2 commits November 6, 2025 15:01
implement tests for SpanUtils
refactoring
fix memcmp usage
fix variable name
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SergiusTheBest SergiusTheBest merged commit bfc5f67 into main Nov 6, 2025
8 checks passed
@SergiusTheBest SergiusTheBest deleted the KF-27-span-utils branch November 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants