-
Notifications
You must be signed in to change notification settings - Fork 2
KF-27 Add tests for SpanUtils #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive test coverage for the SpanUtils utility functions. The changes include setting up test infrastructure to handle error cases and implementing thorough unit tests for all SpanUtils functions.
- Test infrastructure updates to track calls to
std::_Xinvalid_argumentfor error condition testing - Comprehensive test coverage for all SpanUtils functions including
span_cast,as_bytes,copyTruncate,copyExact,copy,equals,indexOf,split, andatOrDefault - Removal of
using namespace stddirective in favor of explicitstd::prefixes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/pch.h | Adds test infrastructure for tracking _Xinvalid_argument calls and introduces _invoke_watson function |
| test/pch.cpp | Defines global counter for tracking _Xinvalid_argument calls |
| test/SpanUtilsTest.cpp | Comprehensive test suite covering all SpanUtils functions with various scenarios |
| test/CMakeLists.txt | Adds SpanUtilsTest.cpp to the build configuration |
| include/kf/SpanUtils.h | Removes using namespace std and adds explicit std:: prefixes throughout |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
implement tests for SpanUtils refactoring fix memcmp usage fix variable name
e69a1df to
f5a2c52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.