Skip to content

Fix: broken domains flow. #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItzNotABug merged 3 commits into from
Dec 9, 2025
Merged

Fix: broken domains flow. #2693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10a0648
fix: broken domains flow.
ItzNotABug Dec 9, 2025
3c7f636
add: exit confirm.
ItzNotABug Dec 9, 2025
7e8c60c
lint.
ItzNotABug Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions src/lib/studio/domains/manage/table.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
Skeleton,
Divider
} from '@appwrite.io/pink-svelte';
import { resolve } from '$app/paths';
import { goto } from '$app/navigation';
import { Click, trackEvent } from '$lib/actions/analytics';
import { regionalProtocol } from '$routes/(console)/project-[region]-[project]/store';
import DeleteDomainModal from '$routes/(console)/project-[region]-[project]/sites/site-[site]/domains/deleteDomainModal.svelte';
Expand All @@ -32,11 +30,13 @@
let {
siteId,
region,
projectId
projectId,
onAddNewDomain = null
}: {
siteId: string;
region: string;
projectId: string;
onAddNewDomain?: () => void;
} = $props();

let loading = $state(true);
Expand Down Expand Up @@ -82,18 +82,6 @@
previousDeleteState = showDelete;
previousRetryState = showRetry;
});

const addDomainUrl = $derived.by(() => {
const baseUrl = resolve(
'/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain',
{
region,
project: projectId,
site: siteId
}
);
return `${baseUrl}?types=false`;
});
</script>

<Table.Root columns={[{ id: 'domain' }, { id: 'actions', width: 40 }]} let:root>
Expand Down Expand Up @@ -164,7 +152,7 @@
</Table.Root>

<Layout.Stack style="width: min-content;">
<Button compact on:onclick={async () => await goto(addDomainUrl)}>
<Button compact on:click={() => onAddNewDomain?.()}>
<Icon icon={IconPlus} size="s" />
Add domain
</Button>
Expand Down
6 changes: 4 additions & 2 deletions src/lib/studio/domains/manage/view.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@
domain,
siteId,
region,
projectId
projectId,
onAddNewDomain = null
}: {
show: boolean;
domain: string;
siteId: string;
region: string;
projectId: string;
onAddNewDomain?: () => void;
} = $props();
</script>

Expand All @@ -40,6 +42,6 @@
</Typography.Text>
</Layout.Stack>

<DomainsTable {siteId} {region} {projectId} />
<DomainsTable {siteId} {region} {projectId} {onAddNewDomain} />
</Layout.Stack>
</SideSheet>
2 changes: 1 addition & 1 deletion src/lib/studio/domains/verify/view.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
</script>

{#if show}
<Wizard column columnSize="s" title="Add domain" showExitModal onExit={() => (show = false)}>
<Wizard column columnSize="s" title="Add domain" confirmExit onExit={() => (show = false)}>
<Form onSubmit={verify} bind:isSubmitting>
<Layout.Stack gap="xxl">
<Card.Base radius="s" padding="s">
Expand Down
6 changes: 5 additions & 1 deletion src/lib/studio/studio.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,8 @@
{region}
{projectId}
domain={primaryDomainForSite}
bind:show={showManageDomainsSheet} />
bind:show={showManageDomainsSheet}
onAddNewDomain={() => {
showAddDomainsWizard = true;
showManageDomainsSheet = false;
}} />
Loading