-
Notifications
You must be signed in to change notification settings - Fork 52
Add support for YYYYMMDD_HHMMSS date format (20250527_125703) #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added regex pattern [12]\d{3}[01]\d[0-3]\d_[0-2]\d[0-5]\d[0-5]\d to support date format 20250527_125703 - Updated approved test files to include the new format - Addresses GitHub issue #124 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Reviewer's GuideThis PR extends DateScrubber to recognize the new YYYYMMDD_HHMMSS timestamp pattern by adding the corresponding regex to the supported formats list and updates the approved test fixtures to include the new format. Sequence Diagram: DateScrubber Handling New YYYYMMDD_HHMMSS FormatsequenceDiagram
participant Client
participant DS as DateScrubber
Client->>DS: get_scrubber_for("20250527_125703")
activate DS
DS->>DS: Accesses updated list of supported_formats (incl. YYYYMMDD_HHMMSS)
DS-->>Client: Scrubber (for YYYYMMDD_HHMMSS)
deactivate DS
Updated Class Diagram for DateScrubberclassDiagram
class DateScrubber {
-date_regex: str
+__init__(date_regex: str)
+scrub(text: str) : str
+$get_scrubber_for(text: str, max_dates: int) : Scrubber
+$get_supported_formats() : List<Tuple<str, List<str>>>
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nitsanavni - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary
• Added support for date format
20250527_125703
(YYYYMMDD_HHMMSS) to DateScrubber• Updated test approved files to reflect the new supported format
Test plan
DateScrubber.get_scrubber_for()
Related to #124
🤖 Generated with Claude Code
Summary by Sourcery
Add a regex entry for the YYYYMMDD_HHMMSS format in DateScrubber and update test fixtures accordingly
New Features:
Tests: