Skip to content

Add support for YYYYMMDD_HHMMSS date format (20250527_125703) #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nitsanavni
Copy link
Contributor

@nitsanavni nitsanavni commented May 27, 2025

Summary

• Added support for date format 20250527_125703 (YYYYMMDD_HHMMSS) to DateScrubber
• Updated test approved files to reflect the new supported format

Test plan

  • Existing date scrubber tests pass
  • New format can be detected by DateScrubber.get_scrubber_for()
  • Regex pattern correctly matches valid date/time ranges
  • Updated approved test files

Related to #124

🤖 Generated with Claude Code

Summary by Sourcery

Add a regex entry for the YYYYMMDD_HHMMSS format in DateScrubber and update test fixtures accordingly

New Features:

  • Add support for YYYYMMDD_HHMMSS date format in DateScrubber

Tests:

  • Update approved test files to include the new date format

- Added regex pattern [12]\d{3}[01]\d[0-3]\d_[0-2]\d[0-5]\d[0-5]\d to support date format 20250527_125703
- Updated approved test files to include the new format
- Addresses GitHub issue #124

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

sourcery-ai bot commented May 27, 2025

Reviewer's Guide

This PR extends DateScrubber to recognize the new YYYYMMDD_HHMMSS timestamp pattern by adding the corresponding regex to the supported formats list and updates the approved test fixtures to include the new format.

Sequence Diagram: DateScrubber Handling New YYYYMMDD_HHMMSS Format

sequenceDiagram
    participant Client
    participant DS as DateScrubber

    Client->>DS: get_scrubber_for("20250527_125703")
    activate DS
    DS->>DS: Accesses updated list of supported_formats (incl. YYYYMMDD_HHMMSS)
    DS-->>Client: Scrubber (for YYYYMMDD_HHMMSS)
    deactivate DS
Loading

Updated Class Diagram for DateScrubber

classDiagram
  class DateScrubber {
    -date_regex: str
    +__init__(date_regex: str)
    +scrub(text: str) : str
    +$get_scrubber_for(text: str, max_dates: int) : Scrubber
    +$get_supported_formats() : List<Tuple<str, List<str>>>
  }
Loading

File-Level Changes

Change Details Files
Extend DateScrubber to recognize YYYYMMDD_HHMMSS format
  • Add regex pattern "[12]\d{3}[01]\d[0-3]\d_[0-2]\d[0-5]\d[0-5]\d" to supported formats
  • Include example date "20250527_125703" in the formats list
approvaltests/scrubbers/date_scrubber.py
Update approved test artifacts to include the new date format
  • Add a table row for "20250527_125703" with its regex in the supported formats approval file
tests/scrubbers/test_date_scrubber.test_supported_formats_as_table.approved.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nitsanavni - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nitsanavni
Copy link
Contributor Author

@lexler I've added support for your date format 20250527_125703 from issue #124. The DateScrubber should now recognize this YYYYMMDD_HHMMSS pattern! [comment by Claude]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant