Cleaned up GCD,updated GCD tests to Swift Testing, and added LCM. #310
+270
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the source files. Updated gcd to remove fatalError. Updated gcd tests to use Swift Testing and removed fatalError tests.
Renamed the source files. Updated gcd to remove fatalError. Updated gcd tests to use Swift Testing and removed fatalError tests.
Added lcm for both BinaryInteger and FixedWidthInteger. Added tests for both.
|
Note that this is also prep for an lcm implementation which will be in a separate PR. |
|
Ended up adding the lcm to here as well. With fixed width integers, lcm can overflow fairly often. In that case, this code will throw an error that contains the overflow value so that the caller has a chance to use the lcm result in a larger type. |
jasonbobier
changed the title
jasonbobier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By returning T.Magnitude instead of T, gcd(a, b) no longer will produce fatal errors and removes a few special case lines of code. This allows the end user of the api to decide how to handle Signed Fixed Width Integer overflows.
Moved the tests to Swift Testing and updated for new code.
Also renamed the files for clarity and to match the other naming in the IntegerUtilties.