Fix benchmark visibility #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboemer
force-pushed
the
fboemer/fix-benchmark-visibility
branch
2 times, most recently
from
abe16e8 to
9f07c9c
Compare
fboemer
force-pushed
the
fboemer/fix-benchmark-visibility
branch
from
9f07c9c to
edafb35
Compare
karulont
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopting
InternalImportsByDefaultin #248 broke the benchmarks.This PR fixes the benchmarks & updates CI to compile benchmarks again. Some upstream github-workflows commit must've broken the benchmarking CI at some point. The expected failing CI in #253 shows we're compiling benchmarks now.