ci: Run End-to-End Tests forscratch and swift:slim Base Images
#164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For reference, I extracted the hummingbird + resource example where the expected failure can be observed in the GitHub Action logs. |
herzi
force-pushed
the
testing/release-configuration
branch
from
1a05631 to
b3d7ac1
Compare
herzi
changed the title
scratch and swift:slim Base Images
Collaborator
dimib
approved these changes
Nov 7, 2025
dimib
approved these changes
Nov 7, 2025
euanh
added a commit
that referenced
this pull request
Nov 21, 2025
…nux (#167) Motivation ---------- In #164, @herzi reported a problem building container images based on `swift:slim` on Linux. The root cause of the problem is that Docker Hub now redirects pulls for `swift:slim` to an S3 bucked behind CloudFlare. URLSession on macOS follows the redirect correctly, but URLSession on Linux incorrectly includes an `Authorization` header which S3 rejects. Modifications ------------- Add a URLSession delegate which removes the `Authorization` header when following a redirect. Result ------ Pulling `swift:slim` from Docker Hub works again. Fixes: #166 Test Plan --------- * #164 extended the end-to-end tests to use `swift:slim` as well as `scratch`, demonstrating the problem. The extended tests now pass. * All existing tests continue to pass.
euanh
force-pushed
the
testing/release-configuration
branch
from
b3d7ac1 to
1ea1608
Compare
Collaborator
|
Merged as part of #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It looks like building images with containertool on Linux fails when using
swift:slimas the base image (which is the default base image, I think.Modifications
Update end to end and integration workflows to test both
scratchandswift:slimbase images.Result
End-to-End Tests should now fail in release configuration.
Test Plan
Other tests are not affected by this.