Use cacheDir from CLI flags in loading of generator-settings.pkl
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzensp
changed the title
generator-settings.pkl
bioball
approved these changes
Jul 3, 2024
Member
bioball
left a comment
bioball
left a comment
There was a problem hiding this comment.
When we release this, we should note in the changelog that the behavior of NewProjectEvaluator has changed.
stackoverflow
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defaulting to
PreconfiguredOptions, we ignore--cache-dirand friends, making vendoring impossible.This PR is just the quick patch to solve the immediate problem and not any further cleanup, so as not to give #56 a difficult rebase.