Add shared credentials for Feedbin (feedbin.me → feedbin.com) - #1373
Open
mangeshraut712 wants to merge 1 commit into
Open
mangeshraut712 wants to merge 1 commit into
mangeshraut712 wants to merge 1 commit into
Conversation
feedbin.me sign-in now opens the Feedbin login on feedbin.com.
Contributor
Author
|
Bar check: This meets the shared-credentials bar. feedbin.me and feedbin.com are the same Feedbin account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bar check: This meets the shared-credentials bar. feedbin.me and feedbin.com are the same Feedbin account.
https://feedbin.me/loginredirects tohttps://feedbin.com/login, which returns 200 and includes a password field. A nonexistent path on that host returns 404. A password saved on feedbin.me is the password for that same account on feedbin.com.feedbin.me is marked obsolete because the host redirects to feedbin.com. The redirect is HTTP 301.
Evidence, checked live:
https://feedbin.me/login→ 301https://feedbin.com/login→ 200, titleFeedbin, withinput type="password" name="password".https://feedbin.com/login→ 200 with the same password field.https://feedbin.com/this-path-should-not-exist-4a36→ 404, body text404 Not Found.https://feedbin.me/→ 301https://feedbin.com/.https://feedbin.me/this-path-should-not-exist-4a36→ 301 to feedbin.com, then 404.Overall Checklist
for shared-credentials.json
feedbin.me/loginredirects to the Feedbin sign-in)fromDomainsAreObsoletedis set because feedbin.me redirects to feedbin.com