CI: run PatternRegexpToPasswordRulesConverter tests when converter changes - #1247
Open
mangeshraut712 wants to merge 1 commit into
Open
CI: run PatternRegexpToPasswordRulesConverter tests when converter changes#1247mangeshraut712 wants to merge 1 commit into
mangeshraut712 wants to merge 1 commit into
Conversation
…anges Add a Lint job that runs the converter suite, but only when tools/PatternRegexpToPasswordRulesConverter or lint.yml change, so other PRs do not pay for it. Signed-off-by: Mangesh Raut <mbr63@drexel.edu> Co-authored-by: Mangesh Raut <mangeshraut712@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Checklist
Adds a Lint job that runs
tools/PatternRegexpToPasswordRulesConverter/run-tests.sh, for #1166.@rmondello asked on that issue that the suite only run when the relevant JS files change, so this is not always-on. Other Lint jobs still run on every push/PR. Converter tests run only if
tools/PatternRegexpToPasswordRulesConverter/**or.github/workflows/lint.ymlchanged (git diff --name-onlyagainst the PR base / pushbeforeSHA). Checkout and setup-node use the same SHA pins as the rest oflint.yml.This replaces closed #1193, which added the job but ran it on every Lint workflow.
I ran the suite by hand on this change: