feat: add sorting controls to count-plot chart #109
+54
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to control sorting of count-plot bars from the UI:
- sortBy: sort by total count ("all") or selected/filtered count ("sel")
- sortOrder: ascending or descending order
Special values (null, other) remain at the bottom regardless of sort settings.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Author
|
Hi! We have a use case where we want to sort entries in count-plot chart by the amount of entries matching current selection (in our case it's coming from applying a filter on chart1 and ordering the other charts accordingly) Does it make sense? |
Member
|
Makes sense. Can you execute the test plan and carefully review the code since you used ai to generate it? |
domoritz
reviewed
Dec 1, 2025
| sortBy: "total" | "selected" | undefined, | ||
| sortOrder: "asc" | "desc" | undefined, | ||
| ) { | ||
| // Split into regular items and special items (null, other) |
Member
There was a problem hiding this comment.
This code iterates over the items two times. Would it be faster and simpler to use the special item index like before and then to use slice to split the array?
A unit test could also be good here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sortByoption: sort by total count ("all") or selected/filtered count ("sel")sortOrderoption: ascending (↑) or descending (↓) orderTest plan
🤖 Generated with Claude Code