Fix image load from file descriptor input#1832
Open
d3v07 wants to merge 1 commit into
Open
Conversation
d3v07
force-pushed
the
fix/image-load-dev-fd-input
branch
from
854db14 to
ce8d26b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--inputpaths direct to avoid unnecessary copying./dev/fd/<n>, and archive copy behavior.Root cause
container image load --input /dev/fd/Naccepts a path that is only meaningful in the CLI process. The image service process cannot reopen that caller-owned descriptor, so the load fails before it can consume the archive.Fixes #1429.
Validation
swift build --target ContainerCommandsswift format lint --recursive Sources/ContainerCommands/Image/ImageLoad.swift Tests/ContainerCommandsTests/ImageLoadTests.swiftgit diff --checkI also ran
swift test --filter ImageLoadTests, but this local environment fails before the filtered test target runs because the active developer directory is Command Line Tools and the test build cannot importTesting/XCTest.BUILDING.mddocuments Xcode 26 as the required active developer directory.