fix(version): preserve unspecified commit placeholder#1831
Open
stephenlclarke wants to merge 1 commit into
Open
fix(version): preserve unspecified commit placeholder#1831stephenlclarke wants to merge 1 commit into
stephenlclarke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
When
containeris built without aGIT_COMMITvalue, the C version shim falls back tounspecified.ReleaseVersion.singleLine(appName:)shortened every non-nil commit string to seven characters, so the user-facing version banner displayedcommit: unspeciinstead of the complete placeholder.This keeps missing or placeholder commit values as
unspecified, while preserving the seven-character display for real commit hashes.Testing
Validated with:
swift test --disable-automatic-resolution --filter ContainerVersionTests env -u GIT_COMMIT swift build --disable-automatic-resolution --product container .build/debug/container --versionThe local version smoke check prints: