Allow conditional section to match any value from comma-seperated list#152
Open
jakubmirejovsky wants to merge 1 commit into
Open
Allow conditional section to match any value from comma-seperated list#152jakubmirejovsky wants to merge 1 commit into
jakubmirejovsky wants to merge 1 commit into
Conversation
boutell
reviewed
Jan 25, 2022
boutell
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this contribution. One concern that occurs to me is that someone could be counting on that comma as part of the value they want to match right now, it's not that common but it would be a backwards compatibility break. Another is that we're not doing anything to help them pick a valid value, but that's actually not new. @abea what do you think?
Contributor
|
It is a BC break, as much as I'd like to lean on any problems from it being very rare. A module option (documented) that allows comma separated conditions would resolve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow conditional section to match any value from comma-seperated list.
Prior to this, conditional groups only allowed matching ONE option (eg. from a select dropdown). This should allow matching multiple options.
Useful when you need to show a conditional section based on a select dropdown where more than one option satisfy the condition.
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
What are the specific steps to test this change?
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
Other information:
Needs to be tested properly.