Skip to content

Conversation

@phryneas
Copy link
Member

@phryneas phryneas commented Dec 8, 2025

Update graphql and graphql-language-server packages.

This allows descriptions in executable documents to be parsed correctly.

There is still a bug in graphql-js (open PR: graphql/graphql-js#4517) - but at least documents will parse, which they didn't before.

I've added the bugfix via patch-package.

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

🦋 Changeset detected

Latest commit: f7f90a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-apollo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas phryneas requested a review from jerelmiller December 8, 2025 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

You can download the latest build of the extension for this PR here:
vscode-apollo-0.0.0-build-1765207942.pr-303.commit-bc97a28.zip.

To install the extension, download the file, unzip it and install it in VS Code by selecting "Install from VSIX..." in the Extensions view.

Alternatively, run

code --install-extension vscode-apollo-0.0.0-build-1765207942.pr-303.commit-bc97a28.vsix --force

from the command line.

For older builds, please see the edit history of this comment.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the graphql package from 16.9.0 to 16.12.0 and graphql-language-service from 5.2.2 to 5.5.0. These updates enable proper parsing of descriptions (block string comments) in executable GraphQL documents, a feature that wasn't supported in the previous versions.

  • Updates graphql to 16.12.0 to support descriptions in executable documents
  • Updates graphql-language-service to 5.5.0 which now supports GraphQL v17
  • Adds sample code demonstrating the new description syntax for queries and arguments

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
package.json Updates graphql and graphql-language-service dependency versions
package-lock.json Reflects the updated package versions with integrity hashes and metadata, including expanded peer dependency support for GraphQL v17 in graphql-language-service
sampleWorkspace/clientSchema/src/test.js Demonstrates the newly supported feature with query-level and argument-level descriptions, and adds a second query to the document
.changeset/unlucky-baboons-tickle.md Documents the changes for the changelog with package name and description corrections needed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@phryneas phryneas merged commit 1be1252 into main Dec 8, 2025
12 checks passed
@phryneas phryneas deleted the pr/bump-graphql branch December 8, 2025 17:59
@github-actions github-actions bot mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants