-
Notifications
You must be signed in to change notification settings - Fork 22
bump graphql and LSP packages
#303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f7f90a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You can download the latest build of the extension for this PR here: To install the extension, download the file, unzip it and install it in VS Code by selecting "Install from VSIX..." in the Extensions view. Alternatively, run code --install-extension vscode-apollo-0.0.0-build-1765207942.pr-303.commit-bc97a28.vsix --forcefrom the command line. For older builds, please see the edit history of this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the graphql package from 16.9.0 to 16.12.0 and graphql-language-service from 5.2.2 to 5.5.0. These updates enable proper parsing of descriptions (block string comments) in executable GraphQL documents, a feature that wasn't supported in the previous versions.
- Updates
graphqlto 16.12.0 to support descriptions in executable documents - Updates
graphql-language-serviceto 5.5.0 which now supports GraphQL v17 - Adds sample code demonstrating the new description syntax for queries and arguments
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updates graphql and graphql-language-service dependency versions |
| package-lock.json | Reflects the updated package versions with integrity hashes and metadata, including expanded peer dependency support for GraphQL v17 in graphql-language-service |
| sampleWorkspace/clientSchema/src/test.js | Demonstrates the newly supported feature with query-level and argument-level descriptions, and adds a second query to the document |
| .changeset/unlucky-baboons-tickle.md | Documents the changes for the changelog with package name and description corrections needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update
graphqlandgraphql-language-serverpackages.This allows descriptions in executable documents to be parsed correctly.
There is still a bug in graphql-js (open PR: graphql/graphql-js#4517) - but at least documents will parse, which they didn't before.I've added the bugfix via patch-package.