a-e-r: Add missing peer dependency on graphql.#3496
Merged
abernix merged 4 commits intoapollographql:masterfrom Nov 27, 2019
Merged
a-e-r: Add missing peer dependency on graphql.#3496abernix merged 4 commits intoapollographql:masterfrom
graphql.#3496abernix merged 4 commits intoapollographql:masterfrom
Conversation
This was referenced Nov 11, 2019
The `apollo-engine-reporting` package was absolutely missing its `peerDependencies` specification for `graphql`. The previous commit added it, but we also need to expand it to match the same range as suggested by the rest of the Apollo packages in the Apollo Server monorepo. Ref: https://git.io/JeXBd
abernix
approved these changes
Nov 27, 2019
Member
abernix
left a comment
abernix
left a comment
There was a problem hiding this comment.
Thank you very much for opening this! I made a couple follow-up commits to widen the version range to match that of the other packages in this monorepo, as well as the addition of a CHANGELOG entry.
(I can't promise I'll be able to merge the other PRs of a similar spirit, but I'll try to spread the word. 😉)
abernix
changed the title
graphql.
Contributor
Author
|
Awesome, thanks 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apollo-engine-reportinghas a transitive peer dependency ongraphqlthroughapollo-graphql,apollo-server-types, andgraphql-extensions, and must be marked as such. Cf my article why implicit transitive peer dependencies are bad 🙂As long as you're here, can you please give a look to the following related PRs? 😃
apollo-link-errorapollo-cache@apollo/react-hooks@apollo/react-ssr