adds repeats to try fix len(dns). Issue79#252
adds repeats to try fix len(dns). Issue79#252DanielPerkins7 wants to merge 7 commits intoapel:devfrom
Conversation
resolve apel#79 . i have just looped everything in the try statement although i am not sure if it is whats needed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fails = 0 | ||
| while fails < 3 and len(dns) == 0: | ||
| for line in lines: | ||
| if line.isspace() or line.strip().startswith('#'): |
There was a problem hiding this comment.
The lines inside the for loop should be indented 4 spaces.
| if len(dns) == 0: | ||
| fails = 0 | ||
| while fails < 3 and len(dns) == 0: | ||
| for line in lines: |
There was a problem hiding this comment.
is lines still being defined here?
| # If no valid DNs, SSM cannot receive any messages. | ||
| if len(dns) == 0: | ||
| fails = 0 | ||
| while fails < 3 and len(dns) == 0: |
There was a problem hiding this comment.
fails is never being incremented, so will never reach 3
|
Also, could these changes be rebased into one commit? You might need Tom to help you :) |
resolve apel#79 . i have just looped everything in the try statement although i am not sure if it is whats needed.
Okay, I have tried - but I am at a loss as to why this isn't working. I thought I had it, but it's just added another commit and merge. |
huh, weird. maybe don't worry about it then? |
4 participants
resolve #79