[YUNIKORN-3087] Remove deprecated "subsystem metrics" code #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfred-s
requested review from
pbacsko,
zhuqi-lucas,
FrankYang0529,
lixmgl and
yangwwei
and removed request for
pbacsko and
zhuqi-lucas
|
Kicked off the pre-commit checks |
|
@BarryWu0812 please check the formatting by running "make lint" locally. |
|
Hi @pbacsko , I have fixed the issue. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
- Coverage 82.69% 82.67% -0.02%
==========================================
Files 98 98
Lines 15682 15658 -24
==========================================
- Hits 12968 12946 -22
+ Misses 2439 2437 -2
Partials 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pbacsko
reviewed
Jun 13, 2025
pkg/metrics/queue.go
Outdated
| appMetricsLabel *prometheus.GaugeVec | ||
| // Deprecated - To be removed in 1.7.0. Replaced with queue label Metrics | ||
| appMetricsSubsystem *prometheus.GaugeVec | ||
| appMetricsLabel *prometheus.GaugeVec |
There was a problem hiding this comment.
Nit: now we only have a single metrics for apps, so rename this to appMetrics
pbacsko
reviewed
Jun 13, 2025
wilfred-s
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Removal of the deprecated "subsystem metrics" code:
https://yunikorn.apache.org/docs/1.5.0/metrics/queue
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3087
How should this be tested?
Unit Test:
Screenshots (if appropriate)
Questions: