[XERCESJ-1781] Javadoc adding role attribute to tables #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Nov 26, 2025
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
I'm not sure any of these are presentational tables. role='presentation' typically indicates the table is used for layout; e.g. as an old-fashioned replacement for what we now do with CSS positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion on #68 (comment)
In newer JDK Javadoc will error if a table has no caption and warn if a table's caption is empty. A related OpenJDK issue (https://bugs.openjdk.org/browse/JDK-8247955) states that tables should have the
role="presentation"attribute set to prevent this behaviour. This resolves the problem on recent JDK versions. However, it's worth noting that when using an outdated JDK such as Java 8 this attribute is unknown, which will also result in an error:error: unknown attribute: role