Skip to content

Conversation

@SingingBush
Copy link
Contributor

updating the jars for xml-apis, serializer, and resolver that are in the tools directory. The newer jars have the version number in the filename which will make it easier to see what's actually used.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to figure out how these are actually used. I would have thought all these came from head. I'm surprised we're loading particular jars. We might need to pull in someone who has admin rights on the GitHub repo.

@SingingBush
Copy link
Contributor Author

I need to figure out how these are actually used. I would have thought all these came from head. I'm surprised we're loading particular jars. We might need to pull in someone who has admin rights on the GitHub repo.

They are referenced in the build.xml when setting up classpath for xjavac:

classpath="${build.dir}/classes:${tools.dir}/${jar.apis}:${tools.dir}/${jar.resolver}:${tools.dir}/${jar.serializer}"

but certainly overhauling the build would be good. I'd prefer to just migrate to a maven build. There seems to be a lot of unnecessary stuff in this Ant build. A good starting point could be to drop the deprecated tasks:

  • deprecatedjar
  • deprecatedjars
  • deprecated-bin
  • deprecatedall

@elharo
Copy link
Contributor

elharo commented Nov 19, 2025

I don't think we can drop those targets

@SingingBush SingingBush requested a review from elharo November 25, 2025 10:51
@SingingBush SingingBush requested a review from elharo November 25, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants