Skip to content

feat(cython): expose additional C API symbols in base.pxi#502

Merged
junrushao merged 1 commit intoapache:mainfrom
junrushao:2026-03-10/cython-expose-c-api-symbols
Mar 10, 2026
Merged

feat(cython): expose additional C API symbols in base.pxi#502
junrushao merged 1 commit intoapache:mainfrom
junrushao:2026-03-10/cython-expose-c-api-symbols

Conversation

@junrushao
Copy link
Member

Summary

  • Add Cython declarations for type-registration functions (TVMFFITypeGetOrAllocIndex, TVMFFITypeRegisterField, TVMFFITypeRegisterMetadata, TVMFFITypeRegisterAttr, TVMFFIErrorSetRaisedFromCStr) so Python-side type registration can call these symbols directly through Cython
  • Add missing field-flag constants (SEqHashIgnore, SEqHashDef, ReprOff, CompareOff, HashOff) and the TVMFFISEqHashKind enum
  • Fix TVMFFITypeMetadata.total_size type (int64_t -> int32_t) and add structural_eq_hash_kind field to match the C struct layout
  • Add cause_chain and extra_context fields to the error info struct

Test plan

  • Existing CI tests pass (no behavioral change, declarations only)
  • Verify Cython compilation succeeds with the new declarations via uv pip install --force-reinstall --verbose -e .

🤖 Generated with Claude Code

Sync the Cython declarations in `base.pxi` with the current C API
header so that Python-side type registration and error handling can
call these symbols directly through Cython rather than via ctypes.

Changes:
- Add type-registration functions: TVMFFITypeGetOrAllocIndex,
  TVMFFITypeRegisterField, TVMFFITypeRegisterMetadata,
  TVMFFITypeRegisterAttr, TVMFFIErrorSetRaisedFromCStr
- Add missing field-flag constants: SEqHashIgnore, SEqHashDef,
  ReprOff, CompareOff, HashOff
- Add TVMFFISEqHashKind enum for structural equality/hash kinds
- Fix TVMFFITypeMetadata.total_size type (int64_t -> int32_t) and
  add structural_eq_hash_kind field to match the C struct layout
- Add cause_chain and extra_context fields to the error info struct
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Cython FFI bindings by exposing critical C API symbols and constants, ensuring better alignment between the Python and C interfaces. These changes facilitate more robust Python-side type registration, error handling, and structural equality hashing by providing direct access to underlying C functionalities and correcting struct definitions.

Highlights

  • Cython Declarations: Exposed additional C API symbols for type-registration functions, allowing Python-side type registration to directly call these through Cython.
  • Field Flags and Enum: Added missing field-flag constants (SEqHashIgnore, SEqHashDef, ReprOff, CompareOff, HashOff) and the TVMFFISEqHashKind enum to align with C API definitions.
  • Type Metadata Struct Alignment: Corrected the type of TVMFFITypeMetadata.total_size from int64_t to int32_t and added the structural_eq_hash_kind field to match the C struct layout.
  • Error Info Struct Enhancement: Added cause_chain and extra_context fields to the error information struct for more comprehensive error reporting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/tvm_ffi/cython/base.pxi
    • Added cause_chain and extra_context fields to the TVMFFIErrorInfo struct.
    • Introduced new field flag constants: SEqHashIgnore, SEqHashDef, ReprOff, CompareOff, and HashOff.
    • Defined the TVMFFISEqHashKind enum.
    • Corrected the type of TVMFFITypeMetadata.total_size to int32_t and added structural_eq_hash_kind.
    • Exposed several C API functions for type registration and error handling, including TVMFFITypeGetOrAllocIndex, TVMFFITypeRegisterField, TVMFFITypeRegisterMetadata, TVMFFITypeRegisterAttr, and TVMFFIErrorSetRaisedFromCStr.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Cython definitions in python/tvm_ffi/cython/base.pxi to expose additional C API symbols. The changes include adding new fields to TVMFFIErrorCell, new constants to TVMFFIFieldFlagBitMask, defining the TVMFFISEqHashKind enum, and updating TVMFFITypeMetadata to match the C struct layout. Additionally, several new function declarations from the FFI C API are added. The changes align the Cython definitions with the C header files and appear correct.

@junrushao junrushao merged commit f98ce6d into apache:main Mar 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants