Add __.V() wrapping for Vertex objects in to() and from_() methods #3281
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
VOTE +1 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3281 +/- ##
============================================
+ Coverage 77.87% 78.33% +0.45%
- Complexity 13578 14590 +1012
============================================
Files 1015 1068 +53
Lines 59308 61893 +2585
Branches 6835 7384 +549
============================================
+ Hits 46184 48481 +2297
- Misses 10817 10826 +9
- Partials 2307 2586 +279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Wrap Vertex objects with __.V(vertex.id) in to() and from() steps - Use isinstance() check to only wrap actual Vertex objects - Revert __.V() wrapping for basic gremlin python examples - Update integration tests to match and test new behavior
kirill-stepanishin
force-pushed
the
v-nesting-python
branch
from
7edfdfa to
06e474e
Compare
Contributor
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes edge creation in gremlin-python by automatically wrapping Vertex objects with
__.V(vertex.id)into()andfrom_()methods.Key Changes:
• Wrap Vertex objects with
__.V()into()andfrom_()steps usingisinstance()check• Pass through strings and traversals unchanged
• Update test expectations to verify Vertex wrapping functionality
• Revert manual
__.V()wrapping from basic examples now that driver handles it automaticallyRelates to #3252