feat: introduce batch execution mode #4158
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
frontend
aglinxinyuan
changed the title
Contributor
Author
|
I will mark this PR ready after adding test cases. |
Yicong-Huang
requested changes
Jan 14, 2026
| new CostBasedScheduleGenerator( | ||
| workflowContext, | ||
| physicalPlan, | ||
| physicalPlan.copy(executionMode = workflowContext.workflowSettings.executionMode), |
Contributor
There was a problem hiding this comment.
I don't think this setting should be part of Physical plan. The information is already in workflowContext, why duplicate it again in physical plan?
Contributor
There was a problem hiding this comment.
In fact, please do not add such configuration to physical plan.
frontend/src/app/dashboard/component/user/user-workflow/user-workflow.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
We are introducing a batch execution mode alongside the existing streaming execution mode.
To support this, a new workflow setting called execution mode has been added, along with a corresponding backend flag. Batch and streaming execution are treated as the same level and are represented as an enum in the configuration.
We also introduce a flag named
defaultExecutionMode, whose value is set tostreaming.Any related issues, documentation, discussions?
This PR resolves issue #4157.
How was this PR tested?
Tested using the existing test cases. TBA.
Was this PR authored or co-authored using generative AI tooling?
No.