fix(utils): ensure webdriver timeout compatibility with urllib3 2.x #34440
+336
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes compatibility issues with urllib3 2.x in the webdriver utility by ensuring timeout values are properly converted to float types. The urllib3 library now requires strict type checking for timeout parameters, and string/invalid timeout values were causing failures.
The changes include:
create
method to reduce complexity (addressing ruff C901 error)TESTING INSTRUCTIONS
To run the new unit tests:
bash
pytest tests/unit_tests/utils/webdriver_test.py -v
ADDITIONAL INFORMATION
🤖 Generated with Claude Code
Co-Authored-By: Claude